Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces loom iframes with wistia inline iframes #1443

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ZPain8464
Copy link
Contributor

This PR adds the inline iframes from Wistia for the Routing, Policies, and Custom Domains videos. @nhayfield I had to manually add the iframe parameter to the URL. It seems to work, but I wanted to get your eyes on it to make sure in case I missed something.

@ZPain8464 ZPain8464 requested a review from nhayfield June 7, 2024 13:46
@ZPain8464 ZPain8464 requested a review from a team as a code owner June 7, 2024 13:46
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team June 7, 2024 13:46
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 03f17db
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/66630f32fb80c700089e7739
😎 Deploy Preview https://deploy-preview-1443--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nhayfield nhayfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@ZPain8464 ZPain8464 merged commit 78bf5e5 into main Jun 7, 2024
9 checks passed
@ZPain8464 ZPain8464 deleted the zpain/add-wistia-videos branch June 7, 2024 15:08
@backport-actions-token
Copy link

The backport to 0-26-0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-0-26-0 0-26-0
# Navigate to the new working tree
cd .worktrees/backport-0-26-0
# Create a new branch
git switch --create backport-1443-to-0-26-0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 78bf5e5ca7d595714ce0f3cca4dc120b5b96ca8c
# Push it to GitHub
git push --set-upstream origin backport-1443-to-0-26-0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-0-26-0

Then, create a pull request where the base branch is 0-26-0 and the compare/head branch is backport-1443-to-0-26-0.

ZPain8464 added a commit that referenced this pull request Jun 7, 2024
replcea loom iframes with  wistia inline iframes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants