Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TLS elliptic curve names consistently #759

Closed
kenjenkins opened this issue Jun 21, 2023 · 2 comments · Fixed by #760
Closed

Use TLS elliptic curve names consistently #759

kenjenkins opened this issue Jun 21, 2023 · 2 comments · Fixed by #760

Comments

@kenjenkins
Copy link
Contributor

Page: https://www.pomerium.com/docs/internals/cryptography#encryption-in-transit

What's incorrect or missing

The "Downstream TLS" section includes "secp256r1" in the elliptic curves list, while the "Upstream TLS" section includes "P-256". I think these are two different names for the same curve?

What's the resolution?

If these are indeed the same, we should probably pick one name and use it consistently in both sections.

Reference

@ZPain8464
Copy link
Contributor

ZPain8464 commented Jun 21, 2023

@kenjenkins yeah nice catch. I also noticed this pretty egregious example in the Manual Verification section of Identity Verification; it lists all three aliases. In the OpenSSL command itself, prime256v1 is used.

Do you feel strongly about using any of these aliases? For readability, I feel like "P-256" is the best option, but it might make sense to use the alias used in the OpenSSL command.

@kenjenkins
Copy link
Contributor Author

I think "P-256" probably makes sense.

I'd agree that listing all three names in the Identity Verification page snippet may be overkill, but I don't feel too strongly about it. If we just leave "NIST P-256" in the text, and keep prime256v1 in the openssl command, that's probably fine? My guess is that "P-256" looks enough like prime256v1 that most readers wouldn't be confused by the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants