Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout config names #391

Closed
mnestor opened this issue Feb 12, 2023 · 1 comment
Closed

Timeout config names #391

mnestor opened this issue Feb 12, 2023 · 1 comment
Labels
NeedsMoreData

Comments

@mnestor
Copy link

mnestor commented Feb 12, 2023 •
edited by desimone
Loading

Page: https://www.pomerium.com/docs/${page}

What's incorrect or missing

Config names are referenced 2 different way. I believe they should be <type>_timeout instead of timeout_<type> but then the ENV variables might need to change. Since I don't use ENV variables I'm not sure which way they should go and I cannot find reference to them in the code.

What's the resolution?

Changing the timeout variables to be the right way in the same format in both locations on the page. Since I cannot determine the right way for the ENV I hesitate to submit an incomplete PR for this.
@desimone
Copy link
Collaborator

desimone commented Feb 13, 2023 •
edited
Loading

Updated your issue. It looks like markdown chewed up the<type>

@mnestor mnestor closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsMoreData
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnestor @desimone