Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: combine "The Number of Trusted Hops" with "X-Forwarded-For" settings pages #1476

Closed
kenjenkins opened this issue Jun 25, 2024 · 1 comment · Fixed by #1488
Closed

Comments

@kenjenkins
Copy link
Contributor

Page: https://www.pomerium.com/docs/reference/the-number-of-trusted-hops

What's incorrect or missing

I think this setting would be clearer if it were grouped with https://www.pomerium.com/docs/reference/x-forwarded-for-http-header. The xff_num_trusted_hops and skip_xff_append settings both affect the behavior of the X-Forwarded-For and X-Forwarded-Proto headers, so I think it would be good to document these together like we do with some of the other closely-related settings.

Also, the description could be clearer: "The Number of Trusted Hops setting reverse proxies in front of Pomerium" doesn't make sense.

What's the resolution?

Let's combine these two into an "X-Forwarded-For Settings" page, and provide some more explanation and examples of how/when you might want to use these settings.

@ZPain8464
Copy link
Contributor

@kenjenkins I think this is a reasonable request. I'll do some research on the X-Forwarded-For and X-Forwarded-Proto headers to see how we can better communicate what these settings do.

I may have some questions before pushing a PR. I'll notify you if I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants