You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this setting would be clearer if it were grouped with https://www.pomerium.com/docs/reference/x-forwarded-for-http-header. The xff_num_trusted_hops and skip_xff_append settings both affect the behavior of the X-Forwarded-For and X-Forwarded-Proto headers, so I think it would be good to document these together like we do with some of the other closely-related settings.
Also, the description could be clearer: "The Number of Trusted Hops setting reverse proxies in front of Pomerium" doesn't make sense.
What's the resolution?
Let's combine these two into an "X-Forwarded-For Settings" page, and provide some more explanation and examples of how/when you might want to use these settings.
The text was updated successfully, but these errors were encountered:
@kenjenkins I think this is a reasonable request. I'll do some research on the X-Forwarded-For and X-Forwarded-Proto headers to see how we can better communicate what these settings do.
I may have some questions before pushing a PR. I'll notify you if I do.
Page: https://www.pomerium.com/docs/reference/the-number-of-trusted-hops
What's incorrect or missing
I think this setting would be clearer if it were grouped with https://www.pomerium.com/docs/reference/x-forwarded-for-http-header. The
xff_num_trusted_hops
andskip_xff_append
settings both affect the behavior of theX-Forwarded-For
andX-Forwarded-Proto
headers, so I think it would be good to document these together like we do with some of the other closely-related settings.Also, the description could be clearer: "The Number of Trusted Hops setting reverse proxies in front of Pomerium" doesn't make sense.
What's the resolution?
Let's combine these two into an "X-Forwarded-For Settings" page, and provide some more explanation and examples of how/when you might want to use these settings.
The text was updated successfully, but these errors were encountered: