Updates ppl example #1385
Merged
Updates ppl example #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
reviewed
May 7, 2024
content/docs/capabilities/ppl.mdx
Outdated
| - domain: | ||
| is: example.com | ||
| - user: | ||
| - email: |
There was a problem hiding this comment.
If we're going to have just one condition in this block I'd recommend keeping the domain condition rather than email. I think that makes a little more sense as a policy: "allow everyone from this domain except for these two specific users"; otherwise it's not clear why you would need a deny block at all.
| @@ -158,7 +158,7 @@ Entries marked with `*` denote criteria that are only available in the [Enterpri | |||
| | \* `record` | variable | Allows policies to be extended using data from [external data sources](/docs/integrations) | | |||
| | `reject` | Anything. Typically `true`. | Always returns false. The opposite of `accept`. | | |||
| | \* `time_of_day` | [Time of Day Matcher] | Returns true if the time of the request (for the current day) matches the constraints. | | |||
| | `user` | [String Matcher] | Returns true if the logged-in user's id matches the given value. | | |||
| | `user` | [String Matcher] | Returns `true` if the logged-in user's ID matches the supplied value. (The actual value of the user ID claim depends on how the identity provider sets this value.) | | |||
There was a problem hiding this comment.
Thanks, I think this is probably helpful clarification.
backport-actions-token bot
pushed a commit
that referenced
this pull request
May 7, 2024
* updates ppl example * updates ppl example
Merged
ZPain8464
added a commit
that referenced
this pull request
May 7, 2024
Updates ppl example (#1385) * updates ppl example * updates ppl example Co-authored-by: zachary painter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1383
@kenjenkins I only made the changes we discussed. Please feel free to add any other suggestions while we're here.