Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desktop docs #1374

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Update desktop docs #1374

merged 9 commits into from
Apr 26, 2024

Conversation

ZPain8464
Copy link
Contributor

@kenjenkins please let me know if you'd prefer different screenshots or more details for this blurb.

Resolves #1366

@ZPain8464 ZPain8464 requested a review from a team as a code owner April 25, 2024 21:57
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team April 25, 2024 21:57
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 9c27cb6
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/662bf11247a93c000807beeb
😎 Deploy Preview https://deploy-preview-1374--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ZPain8464
Copy link
Contributor Author

@kenjenkins just realized this Pr includes a Zero image. We should probably remove it unless you don't think we need to backport this.

Copy link
Contributor

@kenjenkins kenjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

- **macOS**: Open the `dmg` and move the binary to **Applications**. Interact with the client from the system tray icon.

<details>
<summary>Autostart Pomerium Desktop</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this information available somewhere, but I'd agree that this page might not be the best place for it.

What do you think about moving it onto the https://www.pomerium.com/docs/deploy/clients/pomerium-desktop page, along with the installation instructions?

Comment on lines 27 to 29
:::note TCP Terminology

1. Specify this new Route as a TCP Route by prefixing `tcp+` in the **From** field, along with a port suffix.
In this document, a "TCP route" refers to a route configured to accept TCP connections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea — it's natural for a reader to have the question "what's a TCP route" here.

I think we could make this even clearer by comparing with "regular" http/https routes.

What do you think of something like this?

:::info What's a TCP route?

A TCP route is for use with upstream services that don't speak HTTP — for example
SSH, Redis, or MySQL. With a TCP route, the entire connection is proxied to the
upstream service, rather than each individual request separately.

In Pomerium, TCP routes are denoted with a `tcp+` prefix in the route's **From** URL.

content/docs/capabilities/tcp/client.mdx Outdated Show resolved Hide resolved
content/docs/capabilities/tcp/client.mdx Outdated Show resolved Hide resolved

<Tabs>
<TabItem value="Pomerium Zero" label="Pomerium Zero">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Zero screenshot, but I think it might be better to add this in a separate PR, so we can go ahead and backport this one.


**Tags**: Use tags to sort and organize your TCP routes.
![Adding a new connection in the Pomerium Desktop client](./examples/img/desktop/desktop-new-connection.png)

:::note Long-lived connections behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This admonition feels out of place to me. I think it might make sense to remove it, so this section can focus on the "how-to".

content/docs/capabilities/tcp/client.mdx Outdated Show resolved Hide resolved

Copy the shortcut for the Pomerium Desktop app into `C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Startup`.
The port suffix appended to the **From** route is not used to connect to the Pomerium Proxy service from the internet; this will always be port 443 (unless otherwise defined in the configuration file).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think I deleted a pending comment somehow. I think this could be made a little clearer, along the lines of:

:::tip

The port number in the route **From** URL is not used in the initial connection
to Pomerium itself. This connection will still use port 443, unless you use a
bastion host (see [Advanced configuration](#advanced-configuration) below).

@ZPain8464 ZPain8464 merged commit e06cb43 into main Apr 26, 2024
9 checks passed
@ZPain8464 ZPain8464 deleted the zpain/update-desktop-docs branch April 26, 2024 18:26
backport-actions-token bot pushed a commit that referenced this pull request Apr 26, 2024
* updates desktop images and text

* runs prettier

* removes tabs, adds better images

* fixes links

* Update content/docs/capabilities/tcp/client.mdx

Co-authored-by: Kenneth Jenkins <[email protected]>

* Update content/docs/capabilities/tcp/client.mdx

Co-authored-by: Kenneth Jenkins <[email protected]>

* Update content/docs/capabilities/tcp/client.mdx

Co-authored-by: Kenneth Jenkins <[email protected]>

* adds changes based on feedback

* runs prettier

---------

Co-authored-by: Kenneth Jenkins <[email protected]>
ZPain8464 added a commit that referenced this pull request Apr 26, 2024
Update desktop docs (#1374)

* updates desktop images and text

* runs prettier

* removes tabs, adds better images

* fixes links

* Update content/docs/capabilities/tcp/client.mdx



* Update content/docs/capabilities/tcp/client.mdx



* Update content/docs/capabilities/tcp/client.mdx



* adds changes based on feedback

* runs prettier

---------

Co-authored-by: zachary painter <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Desktop Client documentation around client certificate options
2 participants