Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds query strings to Tabs. Now, when you send a link that includes an anchor link within a Tab, the page will scroll to the correct location.
Note: I did add
queryString
to the Config and Envar Tabs, too. If you click one of these tabs, and then click another Tab in a separate block, with a query string, it will conjoin them. For example:Selecting
baz-a
and thenbar-b
would result in a string like:?foo-a=baz-a&foo-b=bar-b
. A real life example:/docs/identity-providers/github?configuration-settings=environment-variables&get-groups=directory-sync
It's entirely possible that user would unwittingly select both Tabs, which would break the functionality. I want the team's input, but maybe we should only add query strings to one tab block in a page going forward? Happy to document this internally.
Resolves #1288