Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommend using the route logout #120

Closed
desimone opened this issue Sep 22, 2022 · 4 comments
Closed

docs: recommend using the route logout #120

desimone opened this issue Sep 22, 2022 · 4 comments

Comments

@desimone
Copy link
Collaborator

There was a bug causing logout on the authenticate service to work differently from logout on the proxy service. (they were actually using different sessions) The above PR should fix that problem.

However using logout from authenticate is not ideal. It can't delete the cookie on the route itself, and we utilize a caching layer for session access, so it may take a few seconds for the user to appear logged out on the route. We should update the documentation to recommend using the route logout.

Originally posted by @calebdoxsey in pomerium/pomerium#3592 (comment)

@desimone desimone added the docs label Sep 26, 2022
@calebdoxsey calebdoxsey self-assigned this Oct 18, 2022
@calebdoxsey
Copy link
Contributor

I don't know where to document this. We don't actually recommend using the authenticate sign_out endpoint anywhere.

@desimone
Copy link
Collaborator Author

desimone commented Nov 21, 2022

Let's add some text to the single sign out docs page. I think what's missing is:

  1. Use the route scoped special endpoint (vs the authenticate logout endpoint which will not clean up the session cookie).
  2. Explain how to properly use the endpoint with some user flow would be helpful
  3. Explain what is , and isn't happening to the session (e.g. cookie will be deleted but the session will be cached globally for a period of time).
  4. Recommend using the SDKs to make this easier.

@alexrudd2
Copy link
Contributor

@XxEnigmaticxX ket's keep an eye on this. Currently I just redirect people to https://authenticate.<domain>.com/.pomerium/ but the logout link isn't obvious (it's upper-right under the user gravatar)

@ZPain8464
Copy link
Contributor

Fixes this: #429

@desimone I believe we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants