Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor text contrast on some diagram labels in dark mode #1187

Open
kenjenkins opened this issue Jan 22, 2024 · 1 comment
Open

Poor text contrast on some diagram labels in dark mode #1187

kenjenkins opened this issue Jan 22, 2024 · 1 comment

Comments

@kenjenkins
Copy link
Contributor

Page: https://www.pomerium.com/docs/capabilities/original-request-context#example

What's incorrect or missing

In dark mode, some diagram labels all but disappear:

Screen Shot 2024-01-22 at 9 07 12 AM

What's the resolution?

Let's see if there's a way to:

  • put a background behind these labels, or
  • make the label text color dark-mode aware

Docusaurus can be configured to use a different Mermaid theme in dark mode (see https://docusaurus.io/docs/next/markdown-features/diagrams#theming), but the other options I saw didn't seem to help with this issue.

@kenjenkins
Copy link
Contributor Author

To investigate: is there a specific CSS class for these diagram labels that we can target with a dark mode rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant