Docs: azure update #1183
Merged
Docs: azure update #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
reviewed
Jan 23, 2024
| pagination_next: null | ||
| --- | ||
|
|
||
| import Tabs from '@theme/Tabs'; | ||
| import TabItem from '@theme/TabItem'; | ||
|
|
||
| This page will help you configure Pomerium to use your Azure Active Directory as an IdP. It assumes you have already [installed Pomerium](/docs/deploy/) | ||
| # Microsoft Entra ID (Azure Active Directory) |
There was a problem hiding this comment.
I think we can remove this explicit heading line and use the default title instead?
There was a problem hiding this comment.
So this is more of an SEO thing. The title front matter is treated as the title tag (what you'd see in the browser tab). If you don't include an H1 like I have, Docusaurus will use the title front matter value as the H1. Specifically for this guide, including both is redundant, but sometimes the H1 should differ from the title (like the code-server guide). I do this out habit to make sure future pages are treated the same.
There was a problem hiding this comment.
Do you want to update this heading to match the current title then?
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
calebdoxsey
reviewed
Jan 23, 2024
|
|
||
| If you have an Office 365 account, you can use the account's Azure AD instance instead of creating a new one. To find your Office 365 account's Azure AD instance: | ||
| - Install [Pomerium](/docs/deploy/core) | ||
| - Create a free [Microsoft 365 administration account](https://www.microsoft.com/en-us/microsoft-365/business/office-365-administration) (or have admin privileges with an existing Microsoft 365 account) |
There was a problem hiding this comment.
I think you sign up for an Azure account?
There was a problem hiding this comment.
You can do that as well. This article explains it a bit better: https://learn.microsoft.com/en-us/microsoft-365/enterprise/azure-integration?view=o365-worldwide#microsoft-entra-editions-and-microsoft-365-identity-management
calebdoxsey
approved these changes
Jan 24, 2024
kenjenkins
approved these changes
Jan 24, 2024
| pagination_next: null | ||
| --- | ||
|
|
||
| import Tabs from '@theme/Tabs'; | ||
| import TabItem from '@theme/TabItem'; | ||
|
|
||
| This page will help you configure Pomerium to use your Azure Active Directory as an IdP. It assumes you have already [installed Pomerium](/docs/deploy/) | ||
| # Microsoft Entra ID (Azure Active Directory) |
There was a problem hiding this comment.
Do you want to update this heading to match the current title then?
ZPain8464
commented
Jan 24, 2024
backport-actions-token bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* partially updates guide * updates guide through application registration * updats api permissions section * updates pomerium configuration section * updates guide and deletes azure img directory * fixes precheck failures * Update content/docs/identity-providers/azure.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/identity-providers/azure.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/identity-providers/azure.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/identity-providers/azure.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/identity-providers/azure.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/identity-providers/azure.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/identity-providers/azure.mdx --------- Co-authored-by: Kenneth Jenkins <[email protected]>
Merged
ZPain8464
added a commit
that referenced
this pull request
Jan 24, 2024
Docs: azure update (#1183) * partially updates guide * updates guide through application registration * updats api permissions section * updates pomerium configuration section * updates guide and deletes azure img directory * fixes precheck failures * Update content/docs/identity-providers/azure.mdx * Update content/docs/identity-providers/azure.mdx * Update content/docs/identity-providers/azure.mdx * Update content/docs/identity-providers/azure.mdx * Update content/docs/identity-providers/azure.mdx * Update content/docs/identity-providers/azure.mdx * Update content/docs/identity-providers/azure.mdx --------- Co-authored-by: zachary painter <[email protected]> Co-authored-by: Kenneth Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Azure AD idp guide. The update includes:
/azure/image directory and replacing it with a newentradirectoryA few things I need team input on:
/identity-providers/azureto/identity-providers/entra? If so, we'd need to add redirects. I'm for keepingazure, just because redirects become difficult to maintain over time. This page is also indexed asazure, and updating the path could have unforeseen consequences with search engines.Troubleshootingsection under the Directory Sync tab to the troubleshooting page?Fixes #1144