hide the dock on macs #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nhayfield Dock icon still visible on my machine. |
|
Still shows in the dock |
|
weird i will look into plist settings instead then |
|
making a new PR using plist |
|
Tried a few things without success. Hard to work on without a mac. |
|
electron-userland/electron-builder#1456 (comment) everything i can find on this says to add the above options the plist info. maybe it is worth another test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should remove the pomerium icon from the dock on macs.
NEEDS TESTING ON A MAC!
Related issues
Fixes #99
Fixes #97
Checklist
improvement/bug/ etc)