Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version command #343

Merged
merged 2 commits into from
Sep 18, 2023
Merged

update version command #343

merged 2 commits into from
Sep 18, 2023

Conversation

kenjenkins
Copy link
Contributor

Summary

Currently pomerium-cli has both a version command and a --version flag, and the output differs slightly between these two. To ensure that these two stay in sync, change the version command so that it delegates to the root command with the args overwritten to contain just --version.

Related issues

Fixes #336.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

Currently pomerium-cli has both a 'version' command and a '--version'
flag, and the output differs slightly between these two. To ensure that
these two stay in sync, change the 'version' command so that it
delegates to the root command with the '--version' flag set.
@kenjenkins kenjenkins requested a review from a team as a code owner September 18, 2023 21:11
@kenjenkins kenjenkins merged commit fa328e5 into main Sep 18, 2023
3 checks passed
@kenjenkins kenjenkins deleted the kenjenkins/version branch September 18, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version command output differs from --version flag output
3 participants