-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resume() on MP4Sprite causes random video freezes #99
Comments
I don't know what's causing it, since on the LibVLC file, the pause and resume function both use |
My guess is that upon pausing, libVLC frees the video buffer, and then tries to load it again upon resuming. |
What would happen if the two functions used void LibVLC::pause()
{
libvlc_media_player_set_pause(libVlcMediaPlayer, 1);
}
void LibVLC::resume()
{
libvlc_media_player_set_pause(libVlcMediaPlayer, 0);
} |
Why don't you try? I don't think it'll work, since I guess that the
|
I've just tried it out and seems to have the same result. |
No idea then. |
funkin colors but da vid is broken as heck |
Wait, could you try to pause/resume the video without pausing the whole state? |
Just tried it out, and it pauses and unpauses just fine. Also apparently |
After messing with it a bit more, this appears to just be an implementation issue on my end. Checking for isPlaying and doing the syncing & unpausing in resyncVocals makes it work fine now, even if it's frozen for a split second after unpausing. |
Trying to use
resume()
(even if the video is currently playing) will have a random chance of the video feed instantly freezing, freezing for a bit, or just not freezing at all.2022-04-29_23-35-24_NotFunkin.mp4
The text was updated successfully, but these errors were encountered: