Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos will replay if user presses Enter, attempting to skip #7

Closed
deandimarzo opened this issue Aug 13, 2021 · 3 comments
Closed

Videos will replay if user presses Enter, attempting to skip #7

deandimarzo opened this issue Aug 13, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@deandimarzo
Copy link
Contributor

If the user presses "Enter" (attempting to skip an MP4 cutscene), the video will start again but with the original instance of the video still playing in the background. This can lead to an endless pile of repeating videos stacked on top of each other.

Can we block input from the player during cutscenes, or add a "skip" feature?

@polybiusproxy
Copy link
Owner

Hi there!
Right now, videos don't check for input, so they can't be skippable.
When you press Enter, you're playing the video again, since it just adds the video.

However, I'm working on it.

@polybiusproxy polybiusproxy added the bug Something isn't working label Aug 13, 2021
@deandimarzo
Copy link
Contributor Author

Fixed this one by adding a Bool flag in StoryMenuState.hx that gets turned on at the start of the cutscene, and if the cutscene gets triggered again, instead calls onVLCComplete() to force the cutscene to end, and move on to the song.

@polybiusproxy
Copy link
Owner

Fixed this one by adding a Bool flag in StoryMenuState.hx that gets turned on at the start of the cutscene, and if the cutscene gets triggered again, instead calls onVLCComplete() to force the cutscene to end, and move on to the song.

As I said in the other issue, mind making a pull request?
Thanks!

@polybiusproxy polybiusproxy added this to Done in hxCodec Aug 27, 2021
@MAJigsaw77 MAJigsaw77 removed this from Done in hxCodec Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants