Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heaps support? #270

Closed
Gaboose opened this issue May 17, 2023 · 4 comments
Closed

Heaps support? #270

Gaboose opened this issue May 17, 2023 · 4 comments

Comments

@Gaboose
Copy link

Gaboose commented May 17, 2023

Are there any plans to add support for the Heaps engine?

I would imagine this being implemented as another folder hxcodec/heaps next to hxcodec/openfl and hxcodec/flixel with a class that extends h2d.Bitmap and reuses the hxcodec/vlc package underneath.

If this is desired, or at least you're ok with it, I could help by writing a pull request :)

@MAJigsaw77
Copy link
Contributor

Are there any plans to add support for the Heaps engine?

I would imagine this being implemented as another folder hxcodec/heaps next to hxcodec/openfl and hxcodec/flixel with a class that extends h2d.Bitmap and reuses the hxcodec/vlc package underneath.

If this is desired, or at least you're ok with it, I could help by writing a pull request :)

This lib is normally designed to work with Haxe/OpenFL but I don't see why not ig

@Gaboose
Copy link
Author

Gaboose commented May 17, 2023

On further investigation it seems I can't use LibVLC.hx while targeting hashlink, even if I tell it to output c code (-hl out/main.c).

./hxCodec/hxcodec/vlc/LibVLC.hx:174: characters 55-90 : You cannot access the cpp package while targeting hl (for cpp.RawConstPointer)
./hxCodec/hxcodec/vlc/VLCBitmap.hx:9: characters 8-26 : ... referenced here
./hxCodec/hxcodec/heaps/VideoBitmap.hx:4: characters 8-29 : ... referenced here
src/Main.hx:1: characters 8-33 : ... referenced here

And heaps doesn't support the cpp target (1) (2).

So now I'm not sure how to do this anymore, or if it's even possible.

I already made some preparatory work, I moved openfl dependencies from hxcodec/vlc to hxcodec/openfl in this commit: c7be941. But I guess there's no point in making a pull request anymore. Just posting it here, in case anyone finds it useful.

@polybiusproxy
Copy link
Owner

On further investigation it seems I can't use LibVLC.hx while targeting hashlink, even if I tell it to output c code (-hl out/main.c).

./hxCodec/hxcodec/vlc/LibVLC.hx:174: characters 55-90 : You cannot access the cpp package while targeting hl (for cpp.RawConstPointer)
./hxCodec/hxcodec/vlc/VLCBitmap.hx:9: characters 8-26 : ... referenced here
./hxCodec/hxcodec/heaps/VideoBitmap.hx:4: characters 8-29 : ... referenced here
src/Main.hx:1: characters 8-33 : ... referenced here

And heaps doesn't support the cpp target (1) (2).

So now I'm not sure how to do this anymore, or if it's even possible.

I already made some preparatory work, I moved openfl dependencies from hxcodec/vlc to hxcodec/openfl in this commit: c7be941. But I guess there's no point in making a pull request anymore. Just posting it here, in case anyone finds it useful.

We use C++ externs in order to use libVLC. It may be possible to make it work with HL, I can think of some ways to implement it.

@EliteMasterEric
Copy link
Collaborator

One way would be to migrate the library to ammer when the new version of that library releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants