Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video disappears when resizing it #188

Closed
Sirox228 opened this issue Sep 11, 2022 · 20 comments
Closed

video disappears when resizing it #188

Sirox228 opened this issue Sep 11, 2022 · 20 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Sirox228
Copy link
Contributor

Sirox228 commented Sep 11, 2022

i need to resize video sprite, to make it smaller, but whenever i call setGraphicSize to videosprite or to videosprite.bitmap or to videohandler, video picture just disappears, i tried to graphic size it without updateHitbox(); result is the same.

@polybiusproxy polybiusproxy added the bug Something isn't working label Sep 11, 2022
@Sirox228
Copy link
Contributor Author

Sirox228 commented Sep 11, 2022

IMG_20220911_114834
this appears in logs when i use setGraphicSize (forgot to say, that all of that i'm doing on android)

@polybiusproxy
Copy link
Owner

polybiusproxy commented Sep 11, 2022

IMG_20220911_114834 this appears in logs when i use setGraphicSize (forgot to say, that all of that i'm doing on android)

Is that everything on the logs?
And can you still hear the video?

@Sirox228
Copy link
Contributor Author

Sirox228 commented Sep 11, 2022

Is that everything on the logs?

there's like 5 another copies of the same log of File reading failed + Vlc could not open the file ..........system_fonts.xml (is on screenshot), but they're not changing anything, they are there even without setGraphicSize and video is working with them :/

@Sirox228
Copy link
Contributor Author

Sirox228 commented Sep 11, 2022

can you still hear the video?

i just tested, audio is still there and working fine

@polybiusproxy
Copy link
Owner

can you still hear the video?

i just tested, audio is still there and working fine

You must also resize the video.
With the VideoSprite class, use bitmap.set_width and bitmap.set_height.

@Sirox228
Copy link
Contributor Author

can you still hear the video?

i just tested, audio is still there and working fine

You must also resize the video. With the VideoSprite class, use bitmap.set_width and bitmap.set_height.

i'll try it right now

@Sirox228
Copy link
Contributor Author

Sirox228 commented Sep 11, 2022

@polybiusproxy it gives same 3 errors as in setGraphicSize. now, video is not disappearing, but it didn't change it's width nor height at all

@polybiusproxy
Copy link
Owner

@polybiusproxy it gives same 3 errors as in setGraphicSize. now, video is not disappearing, but it didn't change it's width nor height at all

Can I get a picture of the problem?

@Sirox228
Copy link
Contributor Author

Sirox228 commented Sep 11, 2022

@polybiusproxy it gives same 3 errors as in setGraphicSize. now, video is not disappearing, but it didn't change it's width nor height at all

Can I get a picture of the problem?

focus on "funkin awards" text on blue screen in bg, it's VideoSprite
this is how it is now:
Screenshot_2022-09-11-13-15-42-346_com coolpeople vshex
that is how it should be:
Screenshot_2022-09-11-13-13-23-706_com vanced android youtube
thats how i call it in code:

var coolingVideo = new VideoSprite(-24, -224);
coolingVideo.bitmap.canSkip = false;
coolingVideo.playVideo(Paths.video('coolingVisualizer'), false, false);
//coolingVideo.setGraphicSize(945, 472);
coolingVideo.antialiasing = true;
coolingVideo.scrollFactor.set(0.9, 0.9);
coolingVideo.bitmap.set_width(150);
coolingVideo.bitmap.set_height(75);
coolingVideo.width = 150;
coolingVideo.height = 75;
//coolingVideo.updateHitbox();
add(coolingVideo);

whenever i call setGraphicSize that is now commented, i have those 3 errors with zoom, source AR and ViewPoint and video disappears. with bitmap.set_width etc. video not disappering, but those 3 errors are still there and video resolution is still the same as it was before i even tried to setGraphicSize it. if i remove graphic sizing and bitmap.set_width etc things, those 3 errors are gone, that means, that those are errors of resizing the video.

@JonnycatMeow
Copy link
Collaborator

JonnycatMeow commented Sep 13, 2022

does the issue still occur now?

@Sirox228
Copy link
Contributor Author

@ItsyourboyJonnycat @polybiusproxy nothing changed after last commit, i added coolingVideo.bitmap.canUseAutoResize = false; but same log and same no resolution change when calling set_width and set_height (setGraphicSize kills videosprite like usual)

@polybiusproxy
Copy link
Owner

@ItsyourboyJonnycat @polybiusproxy nothing changed after last commit, i added coolingVideo.bitmap.canUseAutoResize = false; but same log and same no resolution change when calling set_width and set_height (setGraphicSize kills videosprite like usual)

I don't really know how to fix this, so help would be required.

@polybiusproxy polybiusproxy added the help wanted Extra attention is needed label Sep 14, 2022
@Sirox228
Copy link
Contributor Author

@polybiusproxy try to remove stage3d rendering and return old one, maybe it would work (in hex for windows, that uses old system, it somehow worked?)

@polybiusproxy
Copy link
Owner

@polybiusproxy try to remove stage3d rendering and return old one, maybe it would work (in hex for windows, that uses old system, it somehow worked?)

Maybe a switch between Stage3D and BitmapData will do it...
Could you try to revert commit 46d5f3e on your local machine?

@Sirox228
Copy link
Contributor Author

Sirox228 commented Sep 14, 2022

i tried a moment ago, result is the same

@JonnycatMeow
Copy link
Collaborator

JonnycatMeow commented Nov 17, 2022

is the problem still occurring?

@Sirox228
Copy link
Contributor Author

Sirox228 commented Nov 17, 2022

is the problem still occurring?

no changes that can affect this were done, so yes...

@JonnycatMeow
Copy link
Collaborator

well is fixed now?

@MAJigsaw77
Copy link
Contributor

This issue got fixed rn