Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Height is glitched #131

Closed
crowplexus opened this issue Jun 3, 2022 · 14 comments
Closed

Video Height is glitched #131

crowplexus opened this issue Jun 3, 2022 · 14 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@crowplexus
Copy link
Contributor

crowplexus commented Jun 3, 2022

happens with videos with a specific height, usually 4:3 videos do not have this problem
image

@polybiusproxy
Copy link
Owner

These issues started to appear once libVLC was updated :/
I might have to revert some changes...

@MAJigsaw77
Copy link
Contributor

Dude that was happening even in android with the old libs, you have to fix this

@MAJigsaw77
Copy link
Contributor

The libs aren't the ploblem

@Stilic
Copy link
Contributor

Stilic commented Jun 14, 2022

@polybiusproxy maybe we should rewrite hxcodec
or smth

@polybiusproxy
Copy link
Owner

Dude that was happening even in android with the old libs, you have to fix this

this wasn't designed for android in the first place :/
i can assure that it worked perfectly with the old libs

@BeastlyGhost What are the video dimensions?

@crowplexus
Copy link
Contributor Author

Dude that was happening even in android with the old libs, you have to fix this

this wasn't designed for android in the first place :/ i can assure that it worked perfectly with the old libs

@BeastlyGhost What are the video dimensions?

1278x720

@polybiusproxy
Copy link
Owner

Dude that was happening even in android with the old libs, you have to fix this

this wasn't designed for android in the first place :/ i can assure that it worked perfectly with the old libs
@BeastlyGhost What are the video dimensions?

1278x720

1278 pixels, huh? It will definitely work at 1280x720 px, so try to resize it to that dimensions.

@polybiusproxy
Copy link
Owner

May I ask why it is 1278x720px in the first place?

@MAJigsaw77
Copy link
Contributor

Datee said that the implementation will be for android so I done it already, just fix CPP and done

@MAJigsaw77
Copy link
Contributor

The function then is returning the pixel buffer is format setup

@MAJigsaw77
Copy link
Contributor

You should start from it

@crowplexus
Copy link
Contributor Author

May I ask why it is 1278x720px in the first place?

yeah I don't think it made sense either while the team was working on the animation

@polybiusproxy polybiusproxy added bug Something isn't working help wanted Extra attention is needed labels Jun 17, 2022
@MAJigsaw77
Copy link
Contributor

MAJigsaw77 commented Jun 17, 2022

@BeastlyGhost if this will be pushed this hole issue will gone
#135

@polybiusproxy
Copy link
Owner

This has been fixed! Thanks for letting me know about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants