Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw signing with polkadot.js and parity signer is not possible due to outdated polkadot.js extension version in Chrome and Firefox stores #1268

Closed
2 of 10 tasks
nud3l opened this issue Jul 4, 2023 · 15 comments

Comments

@nud3l
Copy link

nud3l commented Jul 4, 2023

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Support request
  • Other
  • What is the current behavior and expected behavior?

Judging from novasamatech/parity-signer#1332 and #1155, I was expecting that I can sign raw data using accounts in the parity signer via polkadot.js.

However, when I try to sign raw data, I get "Raw data signing not supported for QR wallets" error:

image

When injecting the same account with the parity signer companion extension, I can sign raw data.

  • What is the motivation for changing the behavior?

Polkadot.js extension and the signer companion should behave the same.

  • Please tell us about your environment:
  • Version: 0.44.1

  • Environment:

    • Node.js
    • Browser: Firefox
    • Other (limited support for other environments)
  • Language:

    • JavaScript
    • TypeScript (include tsc --version)
    • Other
@nud3l
Copy link
Author

nud3l commented Jul 4, 2023

I'm thinking it might be related that the versions in the firefox and chrome store 0.44.1 are older than the version in which the fix #1155 is included?

@Tbaut
Copy link
Contributor

Tbaut commented Jul 4, 2023

Indeed, building from master will allow you to sign raw messages. The live extension hasn't got a release since the fix was merged.

@nud3l
Copy link
Author

nud3l commented Jul 5, 2023

Is there any plan to update the version in the Firefox and Chrome stores? I have no issue with updating the polkadot.js, but our average users that use the polkadot signer likely will not go through that.

@nud3l nud3l changed the title Raw signing with polkadot.js and parity signer is not possible Raw signing with polkadot.js and parity signer is not possible due to outdated polkadot.js extension version in Chrome and Firefox stores Jul 5, 2023
@jpangelle
Copy link

FYI, this is also creating an issue for Talisman too since they use the polkadot extension logic:

Currently Talisman inherits its signing logic directly from the polkadot.js extension.

Source

@bkchr
Copy link

bkchr commented Oct 26, 2023

@jacogr would it be possible to get a release out?

@FlorianFranzen
Copy link

@bkchr There has not been no new release in over 2 years! Could we please do something about it? (see #1291 for discussion)

@kianenigma
Copy link

any updates on this? Quite a blocker for many ppl it seems.

In the short term, @Tbaut has told me the only way so to build a custom version of the extension. Do you have the code for that in a fork that we can use?

@Tbaut
Copy link
Contributor

Tbaut commented Apr 5, 2024

If you build master following these instructions, you'll be able to run the latest version of the extension and benefit from the features that have been added in the past years.

@bkchr
Copy link

bkchr commented Apr 5, 2024

We don't have access to the chrome nor firefox stores. I'm on it, but maybe we need to bite the bullet and create a new extension.

@ggwpez
Copy link

ggwpez commented Apr 9, 2024

I think Talisman + Parity Signer can sign raw data.

@TarikGul
Copy link
Member

We don't have access to the chrome nor firefox stores. I'm on it, but maybe we need to bite the bullet and create a new extension.

I like the idea of us having a backup plan. Maybe we can decide a hard date where if we don't get access by then we can start the transition to a new release under a different extension with a migration guide.

@IkerAlus
Copy link

IkerAlus commented Jul 4, 2024

This should be already fixed for Chrome version and (hopefully) also solved for Firefox version in the next days

@kianenigma
Copy link

Yeah, confirming that I have the new version on chrome now ✅

@TarikGul
Copy link
Member

TarikGul commented Jul 8, 2024

Happy to confirm the submission in the Firefox store to update to the latest version of the extension has finally been approved :) Closing!

@TarikGul TarikGul closed this as completed Jul 8, 2024
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants