Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current build seems to be failing #4

Closed
JJ opened this issue Sep 24, 2016 · 3 comments
Closed

Current build seems to be failing #4

JJ opened this issue Sep 24, 2016 · 3 comments
Assignees

Comments

@JJ
Copy link

JJ commented Sep 24, 2016

Check it out at https://travis-ci.org/polds/logrus-papertrail-hook/jobs/145635574

@polds polds self-assigned this Sep 30, 2016
@polds
Copy link
Owner

polds commented Sep 30, 2016

Looks like it's not a huge deal: https://github.com/polds/logrus-papertrail-hook/blob/master/papertrail_test.go#L56 its expecting a papertrail host/port combination to be set in the environment which the build does not have.

I'll look into porting it to a self hosted TCP server for the tests.

@undiabler
Copy link
Collaborator

Made fake tcp request via conn interface #5
I think it will be enough. In hook module we shoud test only if fire function works as expected.
Testing full tcp/upd connect with sending data is superfluously. There are tests in dial package.

@polds
Copy link
Owner

polds commented Jan 10, 2017

@undiabler that looks good to me, thank you. Merged.

@polds polds closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants