Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure empty with_columns is a no-op #15694

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: Ensure empty with_columns is a no-op #15694

merged 1 commit into from
Apr 16, 2024

Conversation

ritchie46
Copy link
Member

fixes #15688

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
@ritchie46 ritchie46 merged commit 8befcd1 into main Apr 16, 2024
19 checks passed
@ritchie46 ritchie46 deleted the columns branch April 16, 2024 11:25
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15694 will not alter performance

Comparing columns (9c2fbd6) with main (111382f)

Summary

✅ 22 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect results from using LazyFrame.cache
1 participant
@ritchie46