Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prepare_expression_for_context shouldn't panic if exceptions raised from optimizer #15681

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: prepare_expression_for_context shouldn't panic if exceptions raised from optimizer #15681

merged 2 commits into from
Apr 16, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 16, 2024 •
edited
Loading

This fixes #15653.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15681 will not alter performance

Comparing reswqa:eval_panic (8261cb4) with main (5e68541)

Summary

✅ 22 untouched benchmarks

@reswqa reswqa marked this pull request as ready for review April 16, 2024 03:32
ritchie46
ritchie46 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple. :)

@ritchie46 ritchie46 merged commit 009b1d3 into pola-rs:main Apr 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

struct.field() PanicException inside list.eval() when dtype is list[null]
2 participants
@reswqa @ritchie46