Allow initialization to fail if the program gets stuck in the postServiceCheck while-loop #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viceCheck while-loop
|
Just wanted to leave a note - this took me a day and a half to resolve why my compiled electron app wouldn't work on other peoples' machines. Finally stumbled across this PR, and using this branch I'm able to try/catch the |
|
I just wanted to add my vote as well. This is causing me issues for development. |
Node 12 fixes
|
is there a reason why this was closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #21. Adds a retry counter and allows the initialization of the library to fail. On Windows systems the smart card resource manager may be unresponsive or not running in case not readers are attached to the system. In that case the initialization will get stuck.