Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a card 'off' event #15

Closed
markreid opened this issue May 25, 2017 · 3 comments
Closed

Emit a card 'off' event #15

markreid opened this issue May 25, 2017 · 3 comments
Milestone

Comments

@markreid
Copy link

First, thanks for writing this library!

I've got a use for it at the moment where it would be useful if the Reader would emit an event when the card is removed. Had a quick look and it'd be a very quick fix; if I submitted a PR would you be interested in merging it in?

Cheers :)

@pokusew pokusew changed the title emit a card 'off' event Emit a card 'off' event May 28, 2017
@pokusew pokusew modified the milestone: 0.6.0 May 28, 2017
@pokusew
Copy link
Owner

pokusew commented Jun 2, 2017

Hi @markreid,

thanks for your interest. It definitely makes sense to add this feature. 👍

I have been doing some improvements recently, so I have implemented this feature too. 😃

These changes are not published yet, but I will release them as a part of the upcoming 0.6.0 release in a week or two.

Could you please test it, if it works for you as expected? (clone repo and then yarn and npm run build, then you can check e.g. npm run example-basic. Thank you very much.

Hope it helps.

PS Don't forget to star ⭐️ my library, if you find it useful. 😃 Thanks.

@markreid
Copy link
Author

markreid commented Jun 3, 2017

Hey @pokusew all working from my end; that's basically how i'd implemented it in my fork.

Thanks 👍

@pokusew
Copy link
Owner

pokusew commented Jul 31, 2017

Hi @markreid,

I finally released and published 0.6.0 version with card.off event support among the others changes (check out the release notes), so I am closing this issue now.

Hope it helps.

@pokusew pokusew closed this as completed Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants