Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent writing artifacts to invalid location #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smidf
Copy link

@smidf smidf commented Aug 20, 2023

If SNAPSHOT_ARTIFACTS value is dynamically obtained from an environment variable, an empty string is set for the non-existing variable. This change prevents writing the artifacts to an invalid / prohibited location.

@smidf smidf force-pushed the prevent-writing-artifacts-to-invalid-location branch from b2a29e0 to bd407de Compare October 31, 2023 17:13
If the value is dynamically obtained from an environment variable, an empty string
is set for the non-existing variable. This change prevents writing the artifacts
to an invalid / prohibited location.
@smidf smidf force-pushed the prevent-writing-artifacts-to-invalid-location branch from bd407de to 5683ee0 Compare February 10, 2024 15:40
@smidf
Copy link
Author

smidf commented Feb 10, 2024

@stephencelis, @mbrandonw Any feedback on this small fix, guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant