Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for linked modules? #37

Open
ptusch opened this issue May 26, 2017 · 2 comments
Open

Support for linked modules? #37

ptusch opened this issue May 26, 2017 · 2 comments

Comments

@ptusch
Copy link

ptusch commented May 26, 2017

Hello,

I wonder if there are plans to support linked packages for this project?
It would be pretty cool if I could npm link my_other_cool_package and then compile it all together.

But when I try that, the program crashes at the point of the require - making links not usable.
Please let me know if you desire a sample "not-working-project" project.

Best regards

@pmq20
Copy link
Owner

pmq20 commented May 27, 2017

Thanks for the feedback. I tried npm link and It seems to be linking to the outside of project root, which causes the problem.

I think I can add a check procedure at compile time to warn the user that some symbolic link links to the outside of the project. I've added this to https://github.com/pmq20/node-compiler/blob/master/ROADMAP.md

@ptusch
Copy link
Author

ptusch commented May 31, 2017

Thanks for your fast response!

I can confirm, that a link within the project itself does work nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants