Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical problem with route_type. Bus and rail trips under one route #61

Closed
tafflin opened this issue Sep 9, 2021 · 9 comments
Closed

Comments

@tafflin
Copy link

tafflin commented Sep 9, 2021

Hi,
I found a critical problem which has an impact on companies using atoc rail data to create shapes and in some other cases.

The problem is that the same route can have trips which belong to different route_types.

I looked throught the .MCA file provided by http:https://data.atoc.org and I can see that the trips of train category OO/XX (route_type=2) and BR (route_type=714) are linked to the same route which has a route_type=2. I checked the data by train_uid and retail_train_id.
The result of the issue is that in GTFS we get a mixed mode route.

Impact: Companies using such GTFS files to generate shapes will have problems trying to generate rail shapes for bus trips. The stop locations of such replacement bus stops are far off the rail tracks

@linusnorton
Copy link
Collaborator

I thought the route took into account the mode, I'll check

@linusnorton
Copy link
Collaborator

@tafflin please try again with release 6.4.1

@tafflin
Copy link
Author

tafflin commented Sep 10, 2021

@linusnorton hi, thanks for the quick update.
I can see that you updated the versions of dependencies. I will let you know asap if that helped

@tafflin
Copy link
Author

tafflin commented Sep 10, 2021

@linusnorton
I compared the new version result and the older version result and they are equal.
The bus trip with route_type=714 (according to the source .mca file) still belongs to the route_type=2 in converted GTFS.
Here is the file I tried converting: https://drive.google.com/file/d/1yIkGpbC96KGYtGFRfoi_6NdlBW8uWJ57/view?usp=sharing

@tafflin
Copy link
Author

tafflin commented Sep 14, 2021

Hi @linusnorton ,
Did you have time to think of a possible solution? It's quite an urgent problem for us.
Do you need maybe additional information from my side?
I checked the conversion once again today on our server with the new source data and there are still bus trips connected to train routes in GTFS.

@linusnorton
Copy link
Collaborator

I haven't had time to take a look. What TUID is causing the problem?

@tafflin
Copy link
Author

tafflin commented Sep 14, 2021

train_uid=S12059

@linusnorton
Copy link
Collaborator

@tafflin this should be fixed in 6.4.2

@tafflin
Copy link
Author

tafflin commented Sep 15, 2021

@linusnorton thank you. I can see ~500 new routes and the situation with replacement buses looks solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants