-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow caller to deal with failure #15
Comments
My suggestion would be that we define a static err |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please update the "unsupported" case to be more useful. You could provide a browser.IsSupported() that returns
true
only on supported platforms.I find the use of build-time handling of different platforms to be overly complex. After reviewing this module and considering writing a pull request, I just went with:
because it could work on more types of Unix systems and more gracefully fails when assumptions are not met.
Adding support for the BROWSER environment variable to that would be even better.
The text was updated successfully, but these errors were encountered: