Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center the map on the user's location #99

Open
nicoledaniels opened this issue Jan 29, 2017 · 4 comments
Open

Center the map on the user's location #99

nicoledaniels opened this issue Jan 29, 2017 · 4 comments
Assignees

Comments

@nicoledaniels
Copy link
Collaborator

Center the Leaflet map on the user's location if provided. The zoom should increase if the user's location is provided. If the location is not provided or geolocation services fails, set the center of the map to Cathy's coordinates.

@vonbearshark
Copy link
Contributor

vonbearshark commented Jan 30, 2017

PR did not address some bugs, so I reverted.

There seems to be this weird bug on Firefox that if a user selects "Not Now", the error function is never called: https://bugzilla.mozilla.org/show_bug.cgi?id=675533.

Likewise, Chrome only supports geolocation through https, which we don't have on our custom domain (which is also a GH Pages site) right now: https://developers.google.com/web/updates/2016/04/geolocation-on-secure-contexts-only. We'll need to set that up first-- @nicoledaniels do you have our Namecheap creds to look into that?

@brlodi
Copy link
Collaborator

brlodi commented Jan 30, 2017

^ That Bugzilla thread is a... well, several cursewords. I'm personally of the mind to say screw it for a bug that just got fixed for future release after 5.5 years of explicitly refusing to implement part of a specification because the devs think Firefox is above it. That's the sort of crap that made me stop using Mozilla software.

@vonbearshark
Copy link
Contributor

Yeah I'm totally cool with a Mozilla conditional that drops the prompt and uses Cathy for now.

@nicoledaniels
Copy link
Collaborator Author

Still working on getting the SSL certs for Google Chrome, but should be coming soon which will fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants