Pin Logos

[vonbearshark]

We need to distinguish the pins based on the data coming in. We need to have at least separate icons/colors for the city 311 and police data, for now. But we also need icons for the campus police data, fire data, health and safety restaurant inspection data, etc.

[brlodi]

In the short term, thoughts on pin color? I'd color code as follows:

• Police – blue (if we want to differentiate campus vs. city could be blue/yellow and blue/white)
• 311 – yellow
• Fire – red
• Health – green

We should be able to do standard pins in straight CSS, unless people feel strongly about generating raster image assets for it?

[vonbearshark]

Those work for me. Just need to make sure it matches up to whatever we use for #37. I think image icons would be a neat feature to have, but we can add them in later if someone gets the energy.

For posterity, here's how we'll implement the icons in the future: https://leafletjs.com/examples/custom-icons/.

[brlodi]

So preferring L.icon to L.divIcon?

[vonbearshark]

It might be simpler, but we can cross that bridge when we revisit it, too. Docs on divIcon for future: https://leafletjs.com/reference.html#divicon

[brlodi]

With regard to color-blindness support, my thinking was to have iconography associated with the pins in addition to color, at least as a long-term. Something like this, but not thrown together in 2 minutes (the 311 numerals don't work at small scale).

[vonbearshark]

Those would be dope for now

[brlodi]

@vonbearshark could you assign me to this issue? I'm working on at least some basic flat-ui icons.
Speaking of the icons, should I create a map-pins directory in the root or nest it within an images directory?
Also, the sources file for these icons is in Illustrator. It's not a huge file but it's definitely a binary file. Should I commit it?

[vonbearshark]

For sure! Thanks, @brlodi! Let's nest it in an assets dir. I think we should keep them out of the git path for now. Maybe we can put the long-term assets' source files in version control, but I think we can get away without it now.

Edit: looks like I can't assign you--could you join the PittCSC org as a member?

[brlodi]

@vonbearshark You'd need to invite me. There's no option for non-members to request membership

[vonbearshark]

Of course there's not. That would be simple. Just sent you an inv

[vonbearshark]

We should delete assets while we're at it

[brlodi]

Should be auto-removed once the files in map-pins are gone, no?

[vonbearshark]

Yeah, that's what I mean