Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated library and 311 WPRDC IDs and Sidebar fix #142

Merged
merged 3 commits into from
Jan 25, 2018

Conversation

seifriedc
Copy link
Collaborator

@seifriedc seifriedc commented Dec 19, 2017

Fixed GET errors, data shows up on the map without errors now. Also made the sidebar closed on mobile by default to close #136.

@seifriedc seifriedc changed the title Updated library and 311 WPRDC IDs Updated library and 311 WPRDC IDs and Sidebar fix Dec 19, 2017
@kingsman142
Copy link
Contributor

//Start with sidebar closed if mobile
if (screen.width <= 800) {
         sidebarToggle.open = 1;
         ...
 }

Are you sure this closes the sidebar? Wouldn't open = 1 mean the sidebar is opened by default? I also saw above this you have:

58. sidebarToggle.open = 1;

This indicates the sidebar will initially be open on both mobile and desktop by default. Therefore, this line is no longer needed if we set sidebarToggle.open = 1 in the following if statements that you moved.

@seifriedc
Copy link
Collaborator Author

Yes, sorry you're right on both accounts. First one might have been a typo. I'll fix this real quick

@kingsman142
Copy link
Contributor

@seifriedc Looks good to me. I checked both of your previous two commits. Merging...

@kingsman142 kingsman142 merged commit 621380e into pittcsc:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar on mobile should not be open by default
2 participants