[#8131] Generate and pass request uuid regardless of sampling rate #8217

yjqg6666 · 2021-09-09T09:50:24Z

Resolve #8131.

Feature

A new header Pinpoint-RequestID is added to pass around request id.

app1 --call--> app2

traced:

app1:

2021-09-09 19:01:23 [INFO] [http-nio-36103-exec-1] logger [ReqId:16a69ca7-aa74-407b-b73d-ec1ba8598970 TxId:7fcc576bf5-zp9gb-new^1631185271343^1 SpanId:1501344449065953024] -- logger msg

app2:

2021-09-09 19:01:21 [INFO] [http-nio-15678-exec-6] logger [ReqId:16a69ca7-aa74-407b-b73d-ec1ba8598970 TxId:7fcc576bf5-zp9gb-new^1631185271343^1 SpanId:-5936260539822966618] -- Request received.

not traced:

app1:

2021-09-09 19:02:26 [INFO] [http-nio-36103-exec-5] logger [ReqId:86bb42ef-265f-41dc-b209-18a898ad229b TxId: SpanId:] -- logger msg

app2:

2021-09-09 19:02:26 [INFO] [http-nio-15678-exec-10] logger [ReqId:86bb42ef-265f-41dc-b209-18a898ad229b TxId: SpanId:] -- Request received.

This feature is disabled by default. It can be enabled by agent configuration "profiler.requestId.enable=true" and add %X{PreqId} to your logger pattern.

If you enabled this feature and set "profiler.http.response.requestId.enable=true" (disabled by default) in agent configuration, a "X-Request-Id" header will be added to response, and the response header name can also be configured by "profiler.http.response.requestId.headerName".

If you set "profiler.http.response.traceId.enable=true" (disabled by default) in agent configuration, a "X-Trace-Id" header will be added to response, and the response header name can also be configured by "profiler.http.response.traceId.headerName".

Tasks

request uuid header reader/writer.
http client call header writer.
add logger MDC (%X{PreqId}).
show request uuid in call tree of web ui if traced.
response request uuid as a header (configurable, disabled by default).
response trace id as a header (configurable, disabled by default).
kafka support(passing uuid, disabled by default, configured by profiler.kafka.requestId.enable)

codecov · 2021-09-09T10:06:10Z

Codecov Report

Merging #8217 (533ccc5) into master (77e606c) will decrease coverage by 0.00%.
The diff coverage is 28.16%.

❗ Current head 533ccc5 differs from pull request most recent head 3445c41. Consider uploading reports for the commit 3445c41 to get more accurate results

@@             Coverage Diff              @@
##             master    #8217      +/-   ##
============================================
- Coverage     39.80%   39.79%   -0.01%     
+ Complexity    11478    11377     -101     
============================================
  Files          3364     3335      -29     
  Lines         89754    89265     -489     
  Branches       9950     9920      -30     
============================================
- Hits          35723    35526     -197     
+ Misses        50979    50681     -298     
- Partials       3052     3058       +6

Impacted Files	Coverage Δ
...trap/plugin/request/DefaultRequestTraceWriter.java	`0.00% <0.00%> (ø)`
...otstrap/plugin/request/ServletRequestListener.java	`0.00% <0.00%> (ø)`
...strap/plugin/response/ServletResponseListener.java	`0.00% <0.00%> (ø)`
...lugin/response/ServletResponseListenerBuilder.java	`0.00% <0.00%> (ø)`
...interceptor/client/ClientCallStartInterceptor.java	`0.00% <0.00%> (ø)`
...ceptor/HttpMethodBaseExecuteMethodInterceptor.java	`0.00% <0.00%> (ø)`
...ientExchangeHandlerImplStartMethodInterceptor.java	`0.00% <0.00%> (ø)`
...r/HttpRequestExecutorExecuteMethodInterceptor.java	`0.00% <0.00%> (ø)`
...netty/interceptor/http/HttpEncoderInterceptor.java	`0.00% <0.00%> (ø)`
...synchttpclient/interceptor/ExecuteInterceptor.java	`0.00% <0.00%> (ø)`
... and 352 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e606c...3445c41. Read the comment docs.

yjqg6666 · 2021-09-18T08:22:03Z

Rebased on master.

yjqg6666 · 2021-09-26T07:34:21Z

Resolve conflicts.

yjqg6666 · 2021-10-22T06:34:53Z

Resolve conflicts.

…heck

…quests

…r and configurable

…f enabled

…r.destroyed

… before add/set header

yjqg6666 · 2022-03-09T02:26:42Z

Rebase on the current master & fix conflicts.

chkch · 2023-05-30T03:48:46Z

This feature is cool and valuable. I would like to know if there is a clear schedule

yjqg6666 · 2024-06-25T06:17:01Z

I will squash the commits and rebase the commits on the current master.

yjqg6666 changed the title ~~Generate and pass request uuid regardless of sampling rate~~ Generate and pass request uuid regardless of sampling rate(WIP) Sep 9, 2021

yjqg6666 force-pushed the request-uuid branch 3 times, most recently from 57a7a33 to f978214 Compare September 10, 2021 05:54

yjqg6666 requested a review from emeroad September 10, 2021 06:44

yjqg6666 changed the title ~~Generate and pass request uuid regardless of sampling rate(WIP)~~ Generate and pass request uuid regardless of sampling rate Sep 10, 2021

yjqg6666 changed the title ~~Generate and pass request uuid regardless of sampling rate~~ [#8131] Generate and pass request uuid regardless of sampling rate Sep 13, 2021

yjqg6666 force-pushed the request-uuid branch from a9ebdaa to 7bc9414 Compare September 14, 2021 09:48

yjqg6666 mentioned this pull request Sep 18, 2021

[#8222] replace logger pattern automatically #8228

Merged

4 tasks

yjqg6666 force-pushed the request-uuid branch 2 times, most recently from c3c245b to 03d4899 Compare September 18, 2021 08:21

yjqg6666 changed the title ~~[#8131] Generate and pass request uuid regardless of sampling rate~~ [#8131] Generate and pass request uuid regardless of sampling rate (WIP) Sep 24, 2021

emeroad added this to the 2.4.0 milestone Sep 24, 2021

yjqg6666 changed the title ~~[#8131] Generate and pass request uuid regardless of sampling rate (WIP)~~ [#8131] Generate and pass request uuid regardless of sampling rate Sep 24, 2021

yjqg6666 force-pushed the request-uuid branch from 027a02c to c2e5add Compare September 26, 2021 07:34

yjqg6666 force-pushed the request-uuid branch from 075b4b2 to e607d97 Compare October 22, 2021 06:34

yjqg6666 force-pushed the request-uuid branch from 861e424 to 533ccc5 Compare October 22, 2021 08:59

yjqg6666 force-pushed the request-uuid branch from 533ccc5 to ff0f8ae Compare November 1, 2021 09:15

emeroad mentioned this pull request Nov 30, 2021

Un sample request keep tracing but not record span and span event and send data #8431

Closed

yjqg6666 added 7 commits March 9, 2022 10:15

[pinpoint-apm#8131] add request uuid support

9a37e65

[pinpoint-apm#8131] RequestTraceWriter header can be null, add null c…

0f17efc

…heck

[pinpoint-apm#8131] add grpc support

a90ea9c

[pinpoint-apm#8131] add httpclient3 support

b05b5ac

[pinpoint-apm#8131] add httpclient4 support

4e8e950

[pinpoint-apm#8131] add netty partial support, only traced requests

36d8372

[pinpoint-apm#8131] add ning support

8aea473

yjqg6666 added 17 commits March 9, 2022 10:16

[pinpoint-apm#8131] add okhttp support

b576867

[pinpoint-apm#8131] add reactor-netty partial support, only traced re…

a2cc6c5

…quests

[pinpoint-apm#8131] add spring-webflux support

a0a8f4e

[pinpoint-apm#8131] add vertx support

b5f1513

[pinpoint-apm#8131] add log4j MDC support

3fad8ac

[pinpoint-apm#8131] add log4j2 MDC support

6e85969

[pinpoint-apm#8131] add logback MDC support

ac8dbc8

[pinpoint-apm#8131] remove unused traceContext

79b5f65

[pinpoint-apm#8131] record&show request id in call tree

1764ef5

[pinpoint-apm#8131] add commented-out agent configuration

4ef3667

[pinpoint-apm#8131] request uuid source can be external request heade…

5735d5c

…r and configurable

[pinpoint-apm#8131] request uuid, update plugins-it

18b934d

[pinpoint-apm#8131] request uuid, response request uuid as a header i…

637d5d4

…f enabled

[pinpoint-apm#8131] response trace id as a header if enabled

b2c60dc

[pinpoint-apm#8131] request uuid, move set response header to listene…

8bc0e78

…r.destroyed

[pinpoint-apm#8131] request uuid, kafka support

9ef0357

[pinpoint-apm#8131] reactor netty plugin, check if the header is sent…

3445c41

… before add/set header

yjqg6666 force-pushed the request-uuid branch from ff0f8ae to 3445c41 Compare March 9, 2022 02:26

emeroad modified the milestones: 2.4.0, 2.5.0 Apr 20, 2022

yjqg6666 mentioned this pull request Aug 17, 2022

Can I add some user information to the http headers? #9130

Open

emeroad modified the milestones: 2.5.0, 2.6.0 Dec 21, 2022

emeroad modified the milestones: 3.0.0, 3.0.1 May 17, 2024

intr3p1d force-pushed the master branch from b78cf0c to d07f80b Compare May 30, 2024 05:40

emeroad force-pushed the master branch from 4b12261 to 0440be3 Compare June 4, 2024 06:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#8131] Generate and pass request uuid regardless of sampling rate #8217

[#8131] Generate and pass request uuid regardless of sampling rate #8217

yjqg6666 commented Sep 9, 2021 •

edited

Loading

codecov bot commented Sep 9, 2021 •

edited

Loading

yjqg6666 commented Sep 18, 2021

yjqg6666 commented Sep 26, 2021 •

edited

Loading

yjqg6666 commented Oct 22, 2021

yjqg6666 commented Mar 9, 2022

chkch commented May 30, 2023

yjqg6666 commented Jun 25, 2024

[#8131] Generate and pass request uuid regardless of sampling rate #8217

Are you sure you want to change the base?

[#8131] Generate and pass request uuid regardless of sampling rate #8217

Conversation

yjqg6666 commented Sep 9, 2021 • edited Loading

Feature

traced:

not traced:

Tasks

codecov bot commented Sep 9, 2021 • edited Loading

Codecov Report

yjqg6666 commented Sep 18, 2021

yjqg6666 commented Sep 26, 2021 • edited Loading

yjqg6666 commented Oct 22, 2021

yjqg6666 commented Mar 9, 2022

chkch commented May 30, 2023

yjqg6666 commented Jun 25, 2024

yjqg6666 commented Sep 9, 2021 •

edited

Loading

codecov bot commented Sep 9, 2021 •

edited

Loading

yjqg6666 commented Sep 26, 2021 •

edited

Loading