-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8001] sampling rate can be updated without restarting application #8002
base: master
Are you sure you want to change the base?
Conversation
Since the samplingRate property is changed to volatile, some ignorable performance penalties may be added. |
Codecov Report
@@ Coverage Diff @@
## master #8002 +/- ##
============================================
- Coverage 39.80% 39.44% -0.36%
+ Complexity 11478 10930 -548
============================================
Files 3364 3158 -206
Lines 89754 86833 -2921
Branches 9950 9833 -117
============================================
- Hits 35723 34251 -1472
+ Misses 50979 49601 -1378
+ Partials 3052 2981 -71
Continue to review full report at Codecov.
|
a530b23
to
430d496
Compare
PR pinpoint-apm/pinpoint-grpc-idl#11 need to be merged and the grpc-idl submodule need to be updated to reference the commit. |
430d496
to
824c90d
Compare
@emeroad The PR action check would fail if the grpc-idl PR is not merged. |
451fb7e
to
3a867ae
Compare
34b5ad0
to
e6ac204
Compare
@emeroad @binDongKim The feature is completed. PTAL. @binDongKim I have changed/added some angular code introduced by the commit. |
1c7b504
to
9b7eb50
Compare
Rebased on the current master. |
… table and make rate cell editable
Rebased on the current master. |
Resolve #8001.
feature
Make the sampling rate mutable at runtime and can update the sampling rate temporarily.
How to use this feature
Method 1
This is the recommended method if you have 'the cluster feature' enabled.
Query/update the sampling rate from Pinpoint web UI.
The config "config.enable.samplingRate" in web need to be enabled, or all of the rate values would be 'N/A'.
Click the cell to edit sampling rate and press 'Enter' to confirm and update.
If you are using percent sampling type, the rate can be a decimal (xx.xx), 1(full sampling), 0 (disable sampling).
If you are using counting sampling type, the rate must be an integer (default max 100), 100(full sampling), 0 (disable sampling).
Method 2
This is the only method if you do NOT want to enable the cluster feature.
download arthas
Check the current sampling rate:
The output:
Update sampling rate to 100%:
The output:
It can also be scripted:
Tasks
Changed module