Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider recording application-level call statistics #3649

Open
Xylus opened this issue Dec 22, 2017 · 1 comment
Open

Consider recording application-level call statistics #3649

Xylus opened this issue Dec 22, 2017 · 1 comment

Comments

@Xylus
Copy link
Contributor

Xylus commented Dec 22, 2017

Description

Querying for complex server maps with thousands of agents is slow. Although server map generation code has been improved a lot in 1.7.0, the core of the problem remains - querying for each individual agent's call statistics, especially over a long period of time, is too expensive.
Until now, this was unavoidable as the server map had to include agent level histograms; but with the changes introduced in #3178, it is now possible to ignore agent level call statistics altogether.
(Note agent-level call statistics is still needed to for the histograms, but since they are lazy loaded 1 application at a time, we can stop querying for them for the server map API)

In order to make this happen, application-level call statistics must now be recorded.
This change would theoretically allow great improvement in server map performance as instead of querying for each agent's call statistics for every application, we can simply query once per application.

@Xylus Xylus added this to the 1.7.1 milestone Dec 22, 2017
@Xylus Xylus self-assigned this Dec 22, 2017
@emeroad emeroad modified the milestones: 1.7.2, 1.7.3 Feb 20, 2018
@emeroad emeroad modified the milestones: 1.8.0, 1.8.1 Aug 6, 2018
@emeroad emeroad modified the milestones: 1.8.1, 1.8.2 Oct 25, 2018
@emeroad emeroad modified the milestones: 2.0.0, 2.0.1 Jan 10, 2020
@emeroad emeroad modified the milestones: 2.0.1, 2.0.2 Mar 12, 2020
@emeroad emeroad modified the milestones: 2.0.2, 2.0.3 May 4, 2020
@yjqg6666
Copy link
Contributor

yjqg6666 commented Jun 2, 2020

Awesome feature. We really really need it. Before this feature is realized, we can only export the span data and let the hive/kylin to calculate and query for multiple dimension, it's a huge waste.

@emeroad emeroad modified the milestones: 2.0.3, 2.1.0 Jun 2, 2020
@emeroad emeroad modified the milestones: 2.1.0, 2.2.0 Sep 7, 2020
@emeroad emeroad modified the milestones: 2.2.0, 2.1.1 Dec 2, 2020
@emeroad emeroad modified the milestones: 2.1.1, 2.2.1 Dec 17, 2020
@koo-taejin koo-taejin modified the milestones: 2.2.1, 2.3.0 Jan 21, 2021
@emeroad emeroad removed this from the 2.3.0 milestone May 12, 2021
@emeroad emeroad added this to the 2.3.1 milestone May 12, 2021
@emeroad emeroad modified the milestones: 2.3.1, 2.4.0 Sep 27, 2021
@emeroad emeroad modified the milestones: 2.4.0, 2.5.0 Apr 20, 2022
@emeroad emeroad modified the milestones: 2.5.0, 2.6.0 Dec 21, 2022
@emeroad emeroad modified the milestones: 3.0.0, 3.1.0 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants