-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: read pinpoint config from JVM System properties or environment variables #2904
Labels
Comments
We recommend |
I modified the code to get the config from our cloud config repository. This is really a simple fix. The hardest part is there are no single solution for all environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working out config for my application (deployed using docker to AWS ECS), having to modify the
pinpoint.config
file and redeploy the image is very cumbersome. It'd be great to be able to set the various pinpoint config properties via environment variables or java System properties, e.g.:java -Dpinpoint.profiler.include=com.mycompany.* -jar myapp.jar
.or, Spring-Boot-style:
PINPOINT_PROFILER_INCLUDE=com.mycompany.* java -jar myapp.jar
Would make tweaking configs in a cloud environment much more developer-friendly.
(incidentally there are no good docs on best practices for setting up how much to include in
profiler.include
.. I keep ending up with too much or too little)Thanks!
The text was updated successfully, but these errors were encountered: