Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record txId into logs when sampling using log4j/logback plugin #2896

Open
jiaqifeng opened this issue May 3, 2017 · 1 comment
Open

record txId into logs when sampling using log4j/logback plugin #2896

jiaqifeng opened this issue May 3, 2017 · 1 comment
Labels
proposal

Comments

@jiaqifeng
Copy link
Contributor

goal

If deploying log analysis system such as ELK, we can construct the topology of any transactions from logs according to the txId.

Description

I noticed when sampling is enabled, the txId in log will be empty when sampling flag for current transaction is true. So if such transaction got exception, it's hard to construct the topology as not sampling tx.
@Xylus Xylus added the proposal label Jul 7, 2017
@wingyiu
Copy link

wingyiu commented Mar 19, 2018 •
edited
Loading

alway generate the trx id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wingyiu @Xylus @jiaqifeng