Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 855 clarify mixin docks #857

Merged
merged 6 commits into from
Jun 5, 2020

Conversation

baterson
Copy link
Contributor

@baterson baterson commented Jun 3, 2020

Hello! This is a clarification for the problem from #855

docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
baterson and others added 2 commits June 3, 2020 18:59
Co-authored-by: James Sumners <[email protected]>
Co-authored-by: James Sumners <[email protected]>
@baterson
Copy link
Contributor Author

baterson commented Jun 3, 2020

@jsumners Thanks for helping me out!

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/api.md Outdated Show resolved Hide resolved
Co-authored-by: Matteo Collina <[email protected]>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit afb639c into pinojs:master Jun 5, 2020
hraban added a commit to hraban/pino that referenced this pull request Jan 15, 2021
Restores the original semantics introduced by afb639c (pinojs#857).

Reverts the changes to this documentation from 6e50d72 (pinojs#928) and
6c42f14 (pinojs#926).
@hraban hraban mentioned this pull request Jan 15, 2021
hraban added a commit to hraban/pino that referenced this pull request Jan 15, 2021
Restores the original semantics introduced by afb639c (pinojs#857).

Reverts the changes to this documentation from 6e50d72 (pinojs#928) and
6c42f14 (pinojs#926).

Fixes pinojs#951.
mcollina pushed a commit that referenced this pull request Jan 15, 2021
Restores the original semantics introduced by afb639c (#857).

Reverts the changes to this documentation from 6e50d72 (#928) and
6c42f14 (#926).

Fixes #951.
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants