-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consideration: Auto completion for level option #1807
Comments
Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests. Happy to bump TypeScript! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
The
level
option doesn't support auto-completion:pino/pino.d.ts
Line 347 in 9328478
LiteralUnion
makes this possible (without type errors for customstring
): microsoft/TypeScript#29729This would improve the developer experience.
Implementation
However, I don't know if it can be implemented yet, ...
typescript
4.4 is mentioned here (doesn't supports it → there won't be any auto-completion, the behavior should be the same as now):pino/pino.d.ts
Line 16 in 9328478
but version 5.3.1 is used in
package.json
, this version already supports the technique used inLiteralUnion
:pino/package.json
Line 100 in 9328478
The text was updated successfully, but these errors were encountered: