-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cycle Length and Discounting #298
Comments
I am not against this idea, and specifying the total time and cycle length sounds good. But handling discounting does not need to be so verbose. The way I've been doing it is to define the discount rate as a parameter, so you use rescale_discount_rate just once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current approach to handling discounting seems a bit verbose. As I understand it, you need to use rescale_discount_rate in all discounted outcomes if you use a cycle length other than one year.
That seems like something that could pretty easily be simplified by having an input to run_model representing the cycle length. This is already done for partitioned survival models, but it makes just as much sense for Markov.
Once the timescale is properly defined, no rescaling would be necessary.
Other potential benefits:
The text was updated successfully, but these errors were encountered: