Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChromeSafariBrowser single instance with callbacks #2037

Closed
2 tasks done
zanelladev opened this issue Feb 22, 2024 · 2 comments
Closed
2 tasks done

ChromeSafariBrowser single instance with callbacks #2037

zanelladev opened this issue Feb 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@zanelladev
Copy link

zanelladev commented Feb 22, 2024

  • I have read the Getting Started section
  • I have already searched for the same problem

Environment

Technology Version
Flutter version 3.13.6
Plugin version
Android version 11
iOS version
macOS version
Xcode version
Google Chrome version

Device information: Pixel 3a

Description

In ChromeSafariBrowser, when I use isSingleInstance: true, in Chrome, it works normally, but it doesn't close my tabs after the callback, causing several browser screens to remain open. If I use isSingleInstance: false, sometimes when I open a browser, and then open another one later, it doesn't overwrite the url, so it opens the link from the first browser. In FireFox, isSingleInstance: true, works perfectly.

Expected behavior:

Don't leave tabs open after the callback

Current behavior:

Tabs remain open after the callback

Steps to reproduce

  1. Set isSingleInstance: true,
  2. Open link with Chrome
  3. Callback to your app
  4. Tab still opened in the device

Other case is:

  1. Set isSingleInstance: false,
  2. Open link with Chrome or FireFox
  3. Callback to your app
  4. Open another link with Chrome or FireFox
  5. Browser open the first link, not the second

Images

@zanelladev zanelladev added the bug Something isn't working label Feb 22, 2024
Copy link

👋 @zanelladev

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

@zanelladev
Copy link
Author

The problem is related to the use of android:launchMode="singleInstance" in AndroidManifest.xml along with isSingleInstance: false.

If I set android:launchMode="singleTop", I can use isSingleInstance: false for Chrome and isSingleInstance: true for FireFox and it will work perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant