Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidInternalStoragePathHandler is crashing #1999

Closed
2 tasks done
DougSig opened this issue Jan 26, 2024 · 2 comments
Closed
2 tasks done

AndroidInternalStoragePathHandler is crashing #1999

DougSig opened this issue Jan 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@DougSig
Copy link

DougSig commented Jan 26, 2024

  • I have read the Getting Started section
  • I have already searched for the same problem

Environment

Technology Version
Flutter version 3.16.5
Plugin version 6.0.0
Android version 13
iOS version n/a
macOS version n/a
Xcode version n/a
Google Chrome version 120.0.6099.210

Device information:
Google Pixel 4a

Description

Expected behavior:
App uses InternalStoragePathHandler successfully.

Current behavior:
Crash.

Steps to reproduce

Use the InternalStoragePathHandler on Android:

InAppWebView(
  initialSettings: InAppWebViewSettings(
                webViewAssetLoader: WebViewAssetLoader(
                  domain: '<enter website>', // e.g. 'https://sorare.com'
                  pathHandlers: [
                    if (assetCacheRootPath != null) ...[
                      InternalStoragePathHandler(path: '/', directory: '<directory>'),
                    ],
                  ],
                ),
              ),

There is a crash due to infinite recursion in the library:
https://github.com/pichillilorenzo/flutter_inappwebview/blame/751a104716b2c5158b5cad58347430d01965f00d/flutter_inappwebview_android/lib/src/webview_asset_loader.dart#L198

This was introduced in this PR.

Stacktrace/Logcat

Stacktrace/logcat is not informative, it just says that the InAppWebView widget crashed.

@DougSig DougSig added the bug Something isn't working label Jan 26, 2024
Copy link

👋 @DougSig

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

@DougSig
Copy link
Author

DougSig commented Jan 26, 2024

Duplicate: #1980

@DougSig DougSig closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant