-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBimport false sql error #1617
Comments
I'm running the
suggests that it tries to store queries beginning with ID = 0. If there is already something in the database, this will obviously cause said uniqueness constraint violation. Some questions:
Further ideas:
This all should help us in deciding how to go forward with fixing the issue you are seeing. |
Ah, no. Ignore (most of) what I said above, I read
but failed to fully appreciate what this does - I think we might not be handing this configuration correctly. I'll come back to you soon with a proposed solution. |
Please try branch If you are using Docker, this may be more tricky but we can work this out together if this is the case for you. |
Build the image locally with:
And then replace the reference to edit: Same caveat applies about waiting for the action @DL6ER mentioned to complete first! |
confirmed, no more error / warning logs when DBimport is false. built locally, forgot to mention |
instead opening a new issue, i'd like to ask here hostname.lan is still logged in query log, i am kind a lazy to test it with released FTL (because not really important), but as far as i remember before trying dev-v6 this wasn't happening, maybe related #1247 |
Just to be sure: One of your
and your
|
correct, piholePTR is set to HOSTNAMEFQDN |
It seems like they have always been logged, I verified this also with a v5 Pi-hole. The issue you linked (rather the PR mentioned therein) only added support for PTR lookups of the IP address to reply with the "most appropriate" hostname for the interface a query is received on. Nothing more. The check whether or not this is a special Pi-hole domain (that is also not logged) is found here: Lines 458 to 460 in 1a11413
The conditions are it has to be either However, have a look at #1611 which may give you exactly what you are looking for - even when it means you would have to define these domains there in addition to your |
ok then, back to original issue |
The fix is merged so we can close this. Thank you very much for reporting it! |
i'm sorry, i got a new log after reenabling DBimport 2023-08-06 23:17:04.363 [20482M] INFO: 20000 queries parsed... i just noticed when i see the log size has fatted |
Well, this is indeed strange. Please post the output of
You are free to modify any of the content if you feel this is necessary to preserve your privacy, however, if you replace some test please be crystal clear where you replaced something so we don't start digging into the wrong direction. Note to @DL6ER: Query timestamps are floating-point values, don't cast them to integer before printing! |
I did just push the branch |
/etc/pihole/pihole-FTL.db "SELECT * FROM queries WHERE timestamp BETWEEN 1691318626 AND 1691318627"
before this issue raised, just to be clear here DBimport = true > DBimport = false > report it > got a fix > DBimport = true |
I just wanted to step in and tell you that I have not forgotten to check this out but I'm currently snowed under with work. Things should improve end of next week. I will then come back to you. |
@regae Sorry for the long delay ... we made quite a few changes to the relevant code over the past weeks, and I was hoping you have good news that this is now with the latest |
after enabling dbimport,
only those two logs were logged for running 10 minutes, will wait longer. |
Okay, could you please provide the output of
and
? |
... and ... (I forgot one):
|
the other two returns empty. |
Is this still happening? |
i don't think so, did not appear in the log when i try to reproduce, is it expected behavior? |
Yes, this is expected behavior. There is no history to restore when DBimport is false. |
latest development-v6
happened during exit, and only if DBimport is false.
is it reproducible or just me?
The text was updated successfully, but these errors were encountered: