-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize first name in welcome message #11
Comments
What do you mean with Besides, I think its a good idea to filter out special characters. |
Per telegram documentation only those characters are supported as HTML codes: " < > & Currently |
@jacklul Do you mean breaking like this? I was wondering if we even need to do any encoding. e.g. This name of special characters: It seems Telegram itself handles HTML code inside the name. |
Exactly this, I don't think we need to encode other symbols than " < > & since only those are potential string breakers, right? |
Closing this off for now... |
It seems like
htmlentities
is breaking for some people's names, maybefilter_var($new_user->getFirstName(), FILTER_SANITIZE_SPECIAL_CHARS)
would be better? Anyone with experience in this?The text was updated successfully, but these errors were encountered: