Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of critic_value_new[dones[:, 0.0]] = 0.0 in learn() #9

Open
VijiKK opened this issue Jun 22, 2022 · 1 comment
Open

usage of critic_value_new[dones[:, 0.0]] = 0.0 in learn() #9

VijiKK opened this issue Jun 22, 2022 · 1 comment

Comments

@VijiKK
Copy link

VijiKK commented Jun 22, 2022

critic_value_[dones[:,0]] = 0.0

Hi Phill,

Could you please help me to understand what's this line is for?
critic_value_new[dones[:, 0.0]] = 0.0
Since critic_value_new float variable it cannot be used as array. Should we set just dones[agent_idx] to 0?

Thanks and Regards
Viji

@Vishwanath1999
Copy link

Since Q terminal state is 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants