Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the network parameters about target critic and critic network #10

Open
wallcuber opened this issue Aug 28, 2022 · 1 comment
Open

the network parameters about target critic and critic network #10

wallcuber opened this issue Aug 28, 2022 · 1 comment

Comments

@wallcuber
Copy link

self.target_critic.load_state_dict(critic_state_dict)
above code seems make target critic network's parameter always be same as the critic network's. So what is the purpose? making the network learn more slowly?
Hope somebody help me!

@StimulateX
Copy link

It seems that the parameters of target_critic network should be updated as target_critic = tau*critic + (1-tau)*target_critic. And the actual critic networks is updated according to gradient of loss function. I am working on this code these days. If I am wrong, please correct it and feel free to contact me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants