0.4.5 #85
Merged
0.4.5 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # phenopacket-tools-validator-core/src/main/java/org/phenopackets/phenopackettools/validator/core/impl/DefaultPhenopacketIngestor.java
Added docs according to Harshad's walkthrough
|
@ielis @julesjacobsen -- this is working now, I have added a prototype Ontology validation class. There are some things that potentially should be changed -- in particular, it is not straightforward just to pass "Message" (protobuf) to the validator instead of "Phenopacket". Also, we will need to figure out how to use multiple JSON Schema files and link the Phenopacket to Family and Cohort. |
Add Sphinx documentation
…wRunner`. Signed-off-by: Daniel Danis <[email protected]>
…wRunner`. Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
…ts, families, and cohorts. Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
…ing of absence of the main `Family` components. Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
…r hierarchy of the proto files in `phenopacket-schema`. Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
Signed-off-by: Daniel Danis <[email protected]>
… and `main`. Signed-off-by: Daniel Danis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed API -- simplified a few things. If we like this general structure, we would need some analogous classes for Cohort and Family messages.