Update Java module names #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains updates of the
module-info.javafiles. The module names are changed to stem fromorg.phenopackets.phenopackettools. The version of thephenopacket-schemais bumped tov2.0.2.There is one thing I am not certain about in the
module-info.javaof the builder module. Should we requirecom.google.protobufin a transitive way? There is already a transitive requirement fororg.phenopacket.schema, which requires protobuf. However, theTimestampBuilderincludesTimestampin the API independently of the protobuf, so maybe the transitive requirement is appropriate here too. I'll investigate this further.