Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pa11y Config for Node Pattern Lab 3 #595

Open
jryanconklin opened this issue Aug 15, 2019 · 2 comments
Open

Update Pa11y Config for Node Pattern Lab 3 #595

jryanconklin opened this issue Aug 15, 2019 · 2 comments

Comments

@jryanconklin
Copy link
Contributor

Issue

The default config for pa11y is no longer compatible with Node PL 3.

Analysis

See this PR on the update to resolve: pattern-lab/patternlab-node#1035

const {
  patternPaths,
  navItems,
  // eslint-disable-next-line import/no-unresolved
} = require('../dist/app-node-pl/pl/styleguide/data/patternlab-data.cjs.js');

This PR should account for documenting how to fix as well as tracking the Pattern Lab PR above to see if it's merged. If merged, we don't need to patch Particle. Else, we should create the patch file per docs/patches.md

Confirmation

As a developer, I can run pa11y tests on my Particle.

@jhedstrom
Copy link
Member

This fix should also add pa11y-ci back to the devDependencies section of package.json file, as it is missing at this time.

@jryanconklin
Copy link
Contributor Author

@jhedstrom We don't turn on pally-ci by default on Particle. It's up to the project to enable it considering the size of the Chromium download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants