Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Sass Export Data to Pattern Lab App #593

Open
jryanconklin opened this issue Aug 13, 2019 · 0 comments
Open

Move Sass Export Data to Pattern Lab App #593

jryanconklin opened this issue Aug 13, 2019 · 0 comments
Labels
enhancement good first issue pattern lab

Comments

@jryanconklin
Copy link
Contributor

Issue

Sass exported data is a dependency of the pattern lab app and should not be held in tokens.

Analysis

tokens contains a mixin, /tokens/sass/non-printing/mixins/_export-data.scss that is only used in Pattern Lab. The mixin should be moved directly to the pattern lab app apps/node-pl for better code organization.

Confirmation

As a developer, my global data variables are written to JSON for pattern-lab to use and code is organized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue pattern lab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jryanconklin