Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Icon Generation to Tokens #592

Open
jryanconklin opened this issue Aug 13, 2019 · 0 comments
Open

Move Icon Generation to Tokens #592

jryanconklin opened this issue Aug 13, 2019 · 0 comments
Assignees
@illepic
Labels
enhancement good first issue icons javascript

Comments

@jryanconklin
Copy link
Contributor

Issue

Icon generation in Particle is nested inside the component rather than in tokens

Analysis

The _icons-generated logic for fontawesome lives directly inside the svg component. This work would be better placed inside tokens as lower level generation rather than directly within a pattern.

Confirmation

As a developer, I can use svgs globally without relying on the svg component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illepic illepic

Labels
enhancement good first issue icons javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@illepic @jryanconklin