Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might want to add a note about bumping the package version as well (see my comment in [this PR](https://github.com/pharmaverse/admiraltemplate/pull/72#pullrequestreview-1872726088)) #3

Open
bms63 opened this issue Feb 10, 2024 · 5 comments
Assignees

Comments

@bms63
Copy link
Collaborator

bms63 commented Feb 10, 2024

Might want to add a note about bumping the package version as well (see my comment in this PR)

Originally posted by @manciniedoardo in #1 (comment)

@rossfarrugia
Copy link
Collaborator

@bms63 @zdz2101 do we only have to add this after we release our first version?

@bms63
Copy link
Collaborator Author

bms63 commented Mar 4, 2024

I think the common workflow does this automatically for you, but I'm not sure how the dev website workflow will work here if the vbump isn't used.

image

@manciniedoardo
Copy link
Collaborator

I'll look into this

@rossfarrugia
Copy link
Collaborator

@manciniedoardo i was thinking about this and we only actually need to implement this after our first foundational 0.1.0 release, as nobody is really going to install latest github version until then. we don't even need to update NEWS file until then either, as will explain now on slack channel

@manciniedoardo
Copy link
Collaborator

Makes sense - I’ve since located the documentation for how to implement this, so if you change your mind I can set this up. Otherwise we can keep as an action item for after first release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants